Skip to content

Conversation

@Chihwan-An
Copy link

Added Single Tau Trigger path for Phase2 , worked with Tau HLT Phase2 development group.

It was tested in miniAOD in CMSSW_15_1_0_pre4 and NanoAOD in CMSSW_16_0_0_pre2 , with Z'to tautau samples.

Trigger Efficiency had 48.7% .

  • Phase2 Single_Tau_Trigger Path Added #49569 was submitted before.
    • MinEta for HLT1PFTau EDFilters has a default value of -1.0, which the config understands it as being -2.1.
  • Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 16, 2025

cms-bot internal usage

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47177

  • Found files with invalid states:
    • HLTrigger/Configuration/python/HLT_75e33/modules/hltPreLooseDeepTauPFTauHPS150L2NNeta2p1_cfi.py:

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Chihwan-An for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @SohamBhattacharya, @VourMa, @missirol, @mmusich, @rovere this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49993/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49993/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 15 differences found in the comparisons
  • Reco comparison had 4 failed jobs
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4280229
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4280200
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 227 log files, 198 edm output root files, 53 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2025

test parameters:

  • enable = hlt_p2_integration, hlt_p2_timing
  • workflows = ph2_hlt

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2025

@cmsbuild, please test

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2025

Hi @Chihwan-An,
the timing tests are not completed, but I see that this PR is already failing one of the relval tests: 34434.758_TTbar_14TeV+Run4D121_HLT75e33TimingTiclBarrel, see log.
Can you try to reproduce locally by executing runTheMatrix.py -l 34434.758 locally and fix the configuration? From the exception message it looks like it should be fixable by re-ordering the modules scheduled in the new path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2025

hold

  • Slides are not shared with TSG group yet , shared with Tau HLT phase2 group .

  • the new path should be discussed first in a HLT upgrade meeting @rovere @VourMa FYI

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @mmusich
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Dec 16, 2025
@mmusich
Copy link
Contributor

mmusich commented Dec 17, 2025

@smuzaffar the hlt phase2 timing tests doesn't seem to start, can you check what is the problem with it?

@smuzaffar
Copy link
Contributor

@mmusich , I see that job started an hour ago (https://cmssdt.cern.ch/jenkins/job/ib-run-pr-hlt_p2_timing/241/console) . It should finish soon

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 48KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/49995/summary.html
COMMIT: 57b17b8
CMSSW: CMSSW_16_0_X_2025-12-15-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/49995/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Failed RelVals

----- Begin Fatal Exception 16-Dec-2025 11:15:10 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Dependent module later on Path
  module 'hltParticleFlowRecHitECALUnseeded' depends on 'hltEcalRecHit' which is later on path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47727

@cmsbuild
Copy link
Contributor

Pull request #49637 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47728

@cmsbuild
Copy link
Contributor

Pull request #49637 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-49637/47729

@cmsbuild
Copy link
Contributor

Pull request #49637 was updated. @Martin-Grunewald, @cmsbuild, @mmusich can you please check and sign again.

@Chihwan-An
Copy link
Author

  • Changed to 1 commits
  • GenvisTau for NanoAOD variable recipe added

@mmusich
Copy link
Contributor

mmusich commented Jan 28, 2026

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Size: This PR adds an extra 24KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3976a9/50949/summary.html
COMMIT: d4b20cb
CMSSW: CMSSW_16_1_X_2026-01-27-2300/el8_amd64_gcc13
Additional Tests: HLT_P2_INTEGRATION,HLT_P2_TIMING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/49637/50949/install.sh to create a dev area with all the needed externals and cmssw changes.

HLT P2 Timing: chart

Failed RelVals

----- Begin Fatal Exception 28-Jan-2026 11:08:22 CET-----------------------
An exception of category 'ScheduleExecutionFailure' occurred while
   [0] Calling beginJob
Exception Message:
Unrunnable schedule
Dependent module later on Path
  module 'hltParticleFlowRecHitECALUnseeded' depends on 'hltEcalDetIdToBeRecovered' which is later on path HLT_LooseDeepTauPFTauHPS150_L2NN_eta2p1
----- End Fatal Exception -------------------------------------------------

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants